InitBip1 Static Analysis Findings

InitBip1 Static Analysis Findings

IB1-01S: Illegible Value Literals

Type Severity Location
Code Style InitBip1.sol:L24, L25

Description:

The linked value literals represent a very large number but do so illegibly.

Example:

protocol/contracts/farm/init/InitBip1.sol
23function init() external {
24 IBean(s.c.bean).mint(marketingBudget, 80000000000);
25 IBean(s.c.bean).mint(developmentBudget, 120000000000);
26}

Recommendation:

We advise the special underscore (_) character to be utilised as a separator per thousand units to better represent the linked values (i.e. 10000 becomes 10_000).

Alleviation:

The value representation style was adjusted to contain the underscore separator character and comments were additionally introduced indicating what the exact values are meant to be alleviating this exhibit.

View Fix on GitHub
Navigated to InitBip1 Static Analysis Findings