InitHotFix2 Static Analysis Findings
InitHotFix2 Static Analysis Findings
IHF-01S: Illegible Value Literals
| Type | Severity | Location |
|---|---|---|
| Code Style | 
| InitHotFix2.sol:L19-L36 |
Description:
The linked value literals represent a very large number but do so illegibly.
Example:
protocol/contracts/farm/init/InitHotFix2.sol
18function init() external {19 fixCrates(address(0xf393fb8C4BbF7e37f583D0593AD1d1b2443E205c), 4294966636, 4294966637);20 fixCrates(address(0x9893360c45EF5A51c3B38dcBDfe0039C80fd6f60), 4294966632, 4294966633);21 fixCrates(address(0xa69eb732230F041E62640Da3571F414a01413DB3), 4294966902, 4294966903);22 fixCrates(address(0xe0B54aa5E28109F6Aa8bEdcff9622D61a75E6B83), 4294966559, 4294966560);23 fixCrates(address(0xce66C6A88bD7BEc215Aa04FDa4CF7C81055521D0), 4294964818, 4294964819);24 fixCrates(address(0xb80A3488Bd3f1c5A2D6Fce9B095707ec62172Fb5), 4294965127, 4294965128);25 fixCrates(address(0x7cd222530d4D10E175c939F55c5dC394d51AaDaA), 4294965826, 4294965827);26 fixCrates(address(0x5d12B49c48F756524162BB35FFA61ECEb714280D), 4294936176, 4294936177);27 fixCrates(address(0x6343B307C288432BB9AD9003B4230B08B56b3b82), 4294966454, 4294966455);28 fixCrates(address(0x5068aed87a97c063729329c2ebE84cfEd3177F83), 4294953598, 4294953599);29 fixCrates(address(0x397eADFF98b18a0E8c1c1866b9e83aE887bAc1f1), 4294965442, 4294965443);30 fixCrates(address(0x3bD12E6C72B92C43BD1D2ACD65F8De2E0E335133), 4294846387, 4294846388);31 fixCrates(address(0x215B5b41E224fc24170dE2b20A3e0F619af96A71), 4294953369, 4294953370);32 fixCrates(address(0xFc748762F301229bCeA219B584Fdf8423D8060A1), 4294965079, 4294965080);33 fixCrates(address(0x8D84aA16d6852ee8E744a453a20f67eCcF6C019D), 4294966011, 4294966012);34 fixCrates(address(0xE0f61822B45bb03cdC581283287941517810D7bA), 4294966192, 4294966193);35 fixCrates(address(0x8639AFABa2631C7c09220B161D2b3d0d4764EF85), 4294957800, 4294957801);36 fixCrates(address(0xCc71b8a0B9ea458aE7E17fa232a36816F6B27195), 4294964813, 4294964814);37}Recommendation:
We advise the special underscore (_) character to be utilised as a separator per thousand units to better represent the linked values (i.e. 10000 becomes 10_000).
Alleviation:
The value representation style was adjusted to contain the underscore separator character alleviating this exhibit.
View Fix on GitHub